[CI VALIDATION — do not merge] full agent/supervisor boundary stack (#986+#988+#989+#990)#991
Closed
odesenfans wants to merge 1 commit into
Closed
[CI VALIDATION — do not merge] full agent/supervisor boundary stack (#986+#988+#989+#990)#991odesenfans wants to merge 1 commit into
odesenfans wants to merge 1 commit into
Conversation
odesenfans
force-pushed
the
od/supervisor-vm-id-rename-impl
branch
from
1ae2abe to
2199073
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #991 +/- ##
=======================================
Coverage 79.62% 79.62%
=======================================
Files 208 208
Lines 22920 22920
Branches 1460 1460
=======================================
+ Hits 18249 18251 +2
+ Misses 4293 4292 -1
+ Partials 378 377 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Behaviour-neutral identifier rename so the supervisor objects say what they mean (design: docs/plans/2026-06-19-supervisor-vm-id-rename-design.md). Two axes: - numeric local VM id 'vm_id: int' -> 'vm_index' (MicroVM, VmExecution.vm_index property + create(), network/, hypervisors/, controllers, get_unique_vm_index). - string identity 'vm_hash' -> 'vm_id' on the supervisor objects (VmExecution, VmPool keys/params, LocalSupervisor) and agent reads of that attribute (run/custom_logs/tasks/migration). Left unchanged: the controller's own 'vm_hash: ItemHash' param, the serialized Configuration.vm_id(int)/vm_hash(str) fields and the '"vm_id"'/'"vm_hash"' recreate-dict string keys, the wire CreateVmSpec.vm_id/VmInfo.vm_id, and genuine ItemHash locals. Verified: mypy unchanged at baseline (43/13); full supervisor+migration+network suite green (3 env-only test_interfaces pyroute2/root failures excepted); import-linter 4 kept/0 broken; grep sweep clean (no execution.vm_hash).
odesenfans
force-pushed
the
od/supervisor-vm-id-rename-impl
branch
from
2199073 to
79dff22
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose: run GitHub CI on the combined boundary stack
This branch is the tip of the stacked PRs
dev ← #986 (PR-1) ← #988 (PR-3) ← #989 (PR-2) ← #990 (PR-0), so its diff againstdevis the complete merged result of all four boundary PRs.The per-PR CI workflows only trigger on PRs against
main/dev, so the stacked PRs (#988/#989/#990, based on feature branches) get no automated CI until their bases merge. This draft, do-not-merge PR exists only to run the full CI suite (pytest + mypy + import-boundary + droplet integration + package builds) on the combined result and surface any cross-PR / integration issue the local per-component runs can't.Do NOT merge this — it would squash all four PRs into one and lose the reviewable stack. Merge the individual PRs in order: #986 → #988 → #989 → #990. Close this once they're merged.
Local verification across the stack: 930 unit tests pass (3 env-only
test_interfacespyroute2/root failures excepted), mypy at baseline, import-linter 4 kept / 0 broken.🤖 Generated with Claude Code