Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
The PR raises the minimum supported Rust version (MSRV) to 1.74.0 across all crates and documentation, and adjusts CI settings accordingly.
- Bump
rust-versionto 1.74.0 in eachCargo.tomland README - Add “Unreleased” changelog entry for the MSRV update
- Update CI matrix to test Rust 1.74.0, remove explicit toolchain pin, and simplify caching
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| asn1parse/Cargo.toml | Add rust-version = "1.74.0" and MSRV comment |
| asn1_derive/Cargo.toml | Update rust-version from 1.65.0 to 1.74.0 |
| README.md | Update MSRV text and add “Unreleased” changelog entry |
| Cargo.toml | Bump root crate rust-version to 1.74.0 |
| .github/workflows/ci.yml | Test matrix MSRV bump, remove toolchain pin, simplify cache |
Comments suppressed due to low confidence (3)
.github/workflows/ci.yml:113
- Removing the explicit
toolchainpin can lead to unpredictable CI behavior when the default toolchain changes. Pin the Rust version (e.g.,toolchain: 1.74.0) to ensure reproducible builds.
with:
.github/workflows/ci.yml:121
- Limiting the cache to only the target directory may cause crates to be re-downloaded on each run. Consider restoring registry and git caches to speed up dependency resolution.
path: target/
asn1parse/Cargo.toml:6
- [nitpick] Comment indentation differs from other
Cargo.tomlfiles; align the# This specifies the MSRVcomment with the existing style (two-space indent) for consistency.
# This specifies the MSRV
f65d643 to
1f11d88
Compare
reaperhulk
approved these changes
May 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.