Make Tag::encoded_length public and prepare for releasing 0.24.0#596
Open
facutuesca wants to merge 1 commit intoalex:mainfrom
Open
Make Tag::encoded_length public and prepare for releasing 0.24.0#596facutuesca wants to merge 1 commit intoalex:mainfrom
Tag::encoded_length public and prepare for releasing 0.24.0#596facutuesca wants to merge 1 commit intoalex:mainfrom
Conversation
* Revert `Tag::write_to` back to pub(crate) * Make `Tag::encoded_length` public * Add tests for `Tag::encoded_length` * Release version 0.24.0 Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that making
Tag::write_topublic was not useful, since it also requires makingWriteBuffer's methods public, this PR reverts that change and instead makesTag::encoded_lengthpublic instead.With this, users who want to get the tag bytes from a
Tlvcan useTlv::full_data()andTag::encoded_length()in order to do so.