You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix: make grant_types optional in OpenIdConnectApplicationSettingsClient
The Okta API does not always return grant_types in OIDC app responses,
but the OpenAPI spec marks it as required, causing UnmarshalJSON to fail
with "no value given for required property grant_types".
Applies the same fix pattern introduced in okta#559 (buttonField,
allowMultipleAcsEndpoints) to a field that PR did not cover:
- Remove grant_types from the required list in both spec YAML files
- Remove from requiredProperties validation in UnmarshalJSON
- Add omitempty to the JSON tag
- Update constructor and getters accordingly
Verified against a real Okta org: zero unmarshal errors across all apps
after this change.
Copy file name to clipboardExpand all lines: .generator/okta-management-APIs-oasv3-noEnums-inheritance.yaml
-2Lines changed: 0 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -42689,8 +42689,6 @@ components:
42689
42689
For example, if `https://redirect-*-domain.example.com/oidc/redirect` is configured as a redirect URI, then `https://redirect-1-domain.example.com/oidc/redirect` and `https://redirect-sub-domain.example.com/oidc/redirect` match, but `https://redirect-1.sub-domain.example.com/oidc/redirect` doesn't match.
42690
42690
Only the `https` URI scheme can use wildcard redirect URIs.
42691
42691
> **Note:** The use of wildcard subdomains is discouraged as an insecure practice, since it may allow malicious actors to have tokens or authorization codes sent to unexpected or attacker-controlled pages. Exercise caution if you decide to include a wildcard redirect URI in your configuration.
42692
-
required:
42693
-
- grant_types
42694
42692
OpenIdConnectApplicationSettingsClientKeys:
42695
42693
description: A [JSON Web Key Set](https://tools.ietf.org/html/rfc7517#section-5) for validating JWTs presented to Okta or for encrypting ID tokens minted by Okta for the client
Copy file name to clipboardExpand all lines: okta/api/openapi.yaml
-2Lines changed: 0 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -67055,8 +67055,6 @@ components:
67055
67055
For example, if `https://redirect-*-domain.example.com/oidc/redirect` is configured as a redirect URI, then `https://redirect-1-domain.example.com/oidc/redirect` and `https://redirect-sub-domain.example.com/oidc/redirect` match, but `https://redirect-1.sub-domain.example.com/oidc/redirect` doesn't match.
67056
67056
Only the `https` URI scheme can use wildcard redirect URIs.
67057
67057
> **Note:** The use of wildcard subdomains is discouraged as an insecure practice, since it may allow malicious actors to have tokens or authorization codes sent to unexpected or attacker-controlled pages. Exercise caution if you decide to include a wildcard redirect URI in your configuration.
67058
-
required:
67059
-
- grant_types
67060
67058
type: object
67061
67059
OpenIdConnectApplicationSettingsClientKeys:
67062
67060
description: "A [JSON Web Key Set](https://tools.ietf.org/html/rfc7517#section-5)\
// <x-lifecycle-container><x-lifecycle class=\"ea\"></x-lifecycle></x-lifecycle-container>JWE alg algorithm for encrypting the ID token issued to this client. If this is requested, the response is signed, and then encrypted with the result being a nested JWT. The default, if omitted, is that no encryption is performed. See the [Application Public Keys API](/openapi/okta-management/management/tag/ApplicationSSOPublicKeys/) for more information on encryption keys. See [Key management](https://developer.okta.com/docs/guides/key-management/main/) for more information on how encryption keys are used.
0 commit comments