Add support for stripColor#245
Conversation
|
Hey @slootjes, thank you for using passkit-generator and for contributing! Jest issue is likely to be something related to how the process is run. I'm not sure how you are running the tests, but if you see the test commands, or the test command in Talking about your change, thank you very much for the references. Might sound stupid, but do you confirm it works with both RGB and HEX syntaxes? Just to be sure. Let me know. |
|
I will test it tomorrow. Hex was working as expected at least. I noticed
the test failing but it doesn't seem to relate to my changes, can you
confirm this?
…On Tue, 27 May 2025, 21:01 Alexander Cerutti, ***@***.***> wrote:
*alexandercerutti* left a comment (alexandercerutti/passkit-generator#245)
<#245 (comment)>
Hey @slootjes <https://github.com/slootjes>, thank you for using
passkit-generator and for contributing!
Jest issue is likely to be something related to how the process is run.
I'm not sure how you are running the tests, but if you see the test
commands, or the test command in .vscode/settings.json, you'll see that
there's a flag to use ESM imports.
Talking about your change, thank you very much for the references.
I wonder if Apple forgot such property of if it is part of like a "private
api". Not sure, but I've seen it as well from time to time in other places,
but I've never added it.
Might sound stupid, but do you confirm it works with both RGB and HEX
syntaxes? Just to be sure.
Let me know.
—
Reply to this email directly, view it on GitHub
<#245 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEC47STJITK4CSV47CCKDWT3ASY7PAVCNFSM6AAAAAB6AZVS5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMJTGYYTSOJVG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
The test failing in this PR is because the tests use some certificates and private key I created and set as env var in Github, but they are apparently not accessible from jobs run in PRs. Dunno why. So it fallbacks to file system paths, but the file is not available. Do not worry. I saw the changes but nothing can be broken with these changes. |
|
Thanks for confirming. I tested both hex and rgb and both are working as expected on an iPhone 16e with iOS 18.4.1. |
alexandercerutti
left a comment
There was a problem hiding this comment.
LGTM!
I'll merge it and release it later today. Thank you for your contribution, @slootjes!
If you could, also, leave a ⭐️ to the project, it would be great!
|
Amazing, thanks for your quick response. I've starred the repo and sent you a small donation for the hard work on this project, it's very useful :) |
|
Thank you very much! 🚀 May I ask you in which context are you going to use (or are you already using) passkit-generator? |
|
I will be using it to generate event type tickets with a QR code. |
1b28661
into
alexandercerutti:master
|
Released in v3.4.0 🎉 Thank you very much again for improving passkit-generator @slootjes! |
|
Awesome, happy to help and thanks for the quick merge ans release! |
Added stripColor to OverridablePassProps
Description
First of all, thanks for this library!
I was trying a lot of combinations and noticed that as soon as I set a strip image/buffer, the primary fields text is always rendered with a white color and did not follow the labelColor like I would expect. I stumped upon some places that mentioned "stripColor", tried it and it's indeed working. I couldn't get tests running on Windows 11 with Powershell unfortunately, I only got errors from jest (
SyntaxError: Cannot use import statement outside a module).Hope this change also can help others facing the same issue.
Check relevant checkboxes
npm test) and they passedRelevant information
Sources I could find about "stripColor":