Fix props output#253
Merged
alexandercerutti merged 1 commit intoalexandercerutti:masterfrom Oct 15, 2025
Merged
Conversation
Owner
|
Hi @gpoitch! Thank you for your contribution and for using passkit-generator! That's great, weird I've missed it. Do you have any rush for this fix to land? Otherwise I would merge this in the v3.5.0, which will bring support to iOS 26 changes. Let me know. |
Contributor
Author
|
No rush. Thanks! |
1e5760b
into
alexandercerutti:master
1 of 3 checks passed
Owner
|
Published in v3.5.2 🎉 Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi, great library!
This fixes an issue with the
cloneRecursiveutility function. It wasn't correctly handling arrays of primitives.I encountered the issue when accessing
pass.props, which we use to debug the resulting pass json without building the whole zip.Fields such as:
preferredStyleSchemes: ['posterEventTicket', 'eventTicket']were coming back as:
preferredStyleSchemes: [ { "0": "p", "1": "o", "2": "s", "3": "t", "4": "e", "5": "r", "6": "E", "7": "v", "8": "e", "9": "n", "10": "t", "11": "T", "12": "i", "13": "c", "14": "k", "15": "e", "16": "t" }, { "0": "e", "1": "v", "2": "e", "3": "n", "4": "t", "5": "T", "6": "i", "7": "c", "8": "k", "9": "e", "10": "t" } ]Check relevant checkboxes
npm test) and they passedRelevant information