Merged
Conversation
…ame (PassFieldContent)
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for iOS 26 changes to the Apple Wallet pass generation library. The primary purpose is to extend the library's capabilities to support new iOS 26 features, particularly for semantic boarding passes and enhanced event tickets.
Key changes include:
- Addition of new iOS 26 semantic properties and URL fields for boarding passes
- Support for upcoming pass information entries for enhanced event tickets
- Migration from
FieldtoPassFieldContentnaming to match Apple's terminology - Enhanced relevancy date handling with backward compatibility
Reviewed Changes
Copilot reviewed 19 out of 30 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/schemas/index.ts | Core schema updates including new iOS 26 properties, URL validation, and relevancy date handling |
| src/schemas/UpcomingPassInformation.ts | New schema for upcoming pass information entries supporting event tickets |
| src/schemas/Semantics.ts | Extended semantic properties for iOS 26 boarding pass enhancements |
| src/schemas/PassFields.ts | Updated field references to use new naming convention |
| src/schemas/PassFieldContent.ts | Renamed from Field.ts to match Apple's naming, with deprecation aliases |
| src/PKPass.ts | Added support for upcoming pass information and extended preferredStyleSchemes |
| src/FieldsArray.ts | Updated type references for renamed field types |
| src/messages.ts | Added validation messages for new upcoming pass information feature |
| examples/ | Updated example files with ES modules compatibility fixes |
| package.json | Version bump to 3.5.0-alpha.1 |
| specs/PKPass.spec.mjs | Updated test descriptions and assertions |
Comments suppressed due to low confidence (1)
src/schemas/index.ts:1
- The
datefield inDateInformationschema is marked as required, but in the interface definition it's optional (date?: string | Date;). This creates an inconsistency between the TypeScript interface and Joi validation.
export * from "./Barcode.js";
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #249
Check relevant checkboxes
npm test) and they passedRelevant information