Removed bandwidth parameter#10
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the bandwidth parameter from the generative model training function and its usage, as it was causing script errors and is unnecessary since bandwidth selection is handled automatically through grid search cross-validation.
- Removed the
bandwidthparameter from thetrain_generative_modelfunction signature - Removed the parameter documentation from the function docstring
- Updated the function call in the training script to no longer pass the bandwidth parameter
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/scripts/train_generative_model.py | Removed bandwidth parameter from function call |
| src/european_values/generative_training.py | Removed bandwidth parameter from function signature and documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script was complaining that this parameter was not provided. Since it is part of the gridsearch cross validation it was not necessary.