[maintained fork] Arbitrary stream support, relative gauges, fixes, etc #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Telegraf doesn't support support negative counters, requiring relative gauge values instead. This adds the new method GaugeRelative to allow for this.
Add GaugeRelative to support Telegraf statsd implementation
Please refer to https://github.com/gdiazlo/statsd as a solution to this issue in the original repo alexcesaro#6. This will add the functionality needed while keeping the additional changes that are currently present in this fork. It is useful to have this change as the metrics within a service *shouldn't* stop a service from operating. Currently, it works as is but as soon as `.Clone` is called on the client, it crashes due to a nil conn (caused by this check).
Update client to not require a successful ping
Close relative gauges which was creating corrupt statsd protocol. Also: * Remove TestUDPNotListening which is broken since a51b81. * Fix lint warnings. * Enabled lint checks in travis. * Enabled 1.x and master only for travis as older versions fail to detect go mod support properly.
This implementation does not provide connection state management. Handling connection failures and retrying as necessary should be implemented by the caller, if desired.
(fix 2/2 for alexcesaro#6) Adds an option to facilitate initialising an unmuted client for UDP conns where the server is unreachable.
Merges 'multiplay/master', with unnecessary and duplicated changes removed. Fixes and better testing to come.
Also fixes handling of -0.0 within Gauge, by stripping the sign. This is a follow up fix for alexcesaro#12.
joeycumines
changed the title
joeycumines
changed the title
joeycumines
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created a fork of this repository and intend to maintain it, but I figured I may as well make a PR for visibility, even though this project seems to be dead.
I have avoided any breaking changes (AFAIK), and have unit tested the new features I have added. Test coverage is still at 100%.
As far as I know, mine is the only backwards compatible fork. All that I've seen seem to merge some variation of #7. I've added an option to disable the initial UDP check / ping, but it's still default behavior.
I am no longer the only contributor to my fork, and the change list has grown, so please take a look at https://github.com/joeycumines/statsd/blob/master/README.md .