feat: add sparse file support to builder#321
Open
attilarepka wants to merge 10 commits intoalexcrichton:mainfrom
Open
feat: add sparse file support to builder#321attilarepka wants to merge 10 commits intoalexcrichton:mainfrom
attilarepka wants to merge 10 commits intoalexcrichton:mainfrom
Conversation
Author
|
Hi @alexcrichton! Could you please give a review on this one, when you have some spare time? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds builder support for sparse files using
append_sparse()method. This includes support for extension headers as well.Docs up-to-date and also tried to tests all possible happy scenarios.
Examples only provided in rustdocs.
Fixes #315