Make lookup support struct tag #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkappa
approved these changes
Aug 17, 2020
Comment on lines
+83
to
+87
| // NOTE: Is there any option we need to add? | ||
| // Just treat all tag value as the symbol name for now. | ||
| if val != name { | ||
| continue | ||
| } |
There was a problem hiding this comment.
Great question! To start, I think it would be sufficient to lookup the entire tag value as you do now. In the future, we could allow modifying the tag name as an option to mustache.New().
One use case I can see is reusing the json tag. As that tag may have other values following the comma (e.g omitempty), we may want to split the value and use the first element.
I'd be more than happy to accept it as is though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base on PR #6