Performance: attempt to optimize the ArrayHitCounter by maintaining some state while updating the counter#721
Draft
alexklibisz wants to merge 17 commits intomainfrom
Draft
Performance: attempt to optimize the ArrayHitCounter by maintaining some state while updating the counter#721alexklibisz wants to merge 17 commits intomainfrom
alexklibisz wants to merge 17 commits intomainfrom
Conversation
…ents it needs to iterate over
…ack the min doc IDs
…stiknn into 160-optimize-hit-counter
…stiknn into 160-optimize-hit-counter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
#160, #611
Changes
I had two ideas to speed up the ArrayHitCouner here, but they don't seem to be panning out in the benchmarks:
Testing and Validation
How was it validated?