Fix windows shell

[hossam-houssien]

📺 PR Description

issue #987 and #1004
panic caused by std::process::Command on Windows throwing program not found
the shell names were missing the .exe extension on Windows.
also implemented a default to pwsh.exe if available, gracefully falling back to powershell.exe.

Checklist

• I have added a test case in issue television Crash Report - "0.15.4" - win 11 #987 that reproduces the bug
• I have added a reasonable amount of documentation to the code where appropriate

[alexpasmantier]

Thanks for taking the time to fix this. The solution looks fine to me, just left a couple of comments I think we should address before merging.

[alexpasmantier]

I don't think you want to include this in the PR

[hossam-houssien]

you are right , I though i remove it

[alexpasmantier]

To avoid all that branching, let's just duplicate the executable function and have one for windows and one for unix

[HeyItsGilbert]

Would a using the which crate and a match be better here?

Suggested change

	Shell::Bash => {
	if cfg!(target_os = "windows") {
	"bash.exe"
	} else {
	"bash"
	}
	}
	Shell::Zsh => {
	if cfg!(target_os = "windows") {
	"zsh.exe"
	} else {
	"zsh"
	}
	}
	Shell::Fish => {
	if cfg!(target_os = "windows") {
	"fish.exe"
	} else {
	"fish"
	}
	}
	Shell::Cmd => {
	if cfg!(target_os = "windows") {
	"cmd.exe"
	} else {
	"cmd"
	}
	}
	Shell::Nu => {
	if cfg!(target_os = "windows") {
	"nu.exe"
	} else {
	"nu"
	}
	}
	Shell::Psh => {
	if cfg!(target_os = "windows") {
	static PSH_EXE: std::sync::OnceLock<&'static str> =
	std::sync::OnceLock::new();
	PSH_EXE.get_or_init(|| {
	if std::process::Command::new("pwsh.exe")
	.arg("-Version")
	.output()
	.is_ok()
	{
	"pwsh.exe"
	} else {
	"powershell.exe"
	}
	})
	} else {
	"pwsh"
	}
	}
	Shell::Bash => "bash",
	Shell::Zsh => "zsh",
	Shell::Fish => "fish",
	Shell::Cmd => "cmd",
	Shell::Nu => "nu",
	Shell::Psh => {
	match which("pwsh") {
	Ok(path) => "pwsh",
	Err(_) => "powershell.exe",
	}
	}

[hossam-houssien]

@alexpasmantier it still branching anyway, but if using std::process::Command as @HeyItsGilbert mentioned, this would cut the branch,
@HeyItsGilbert std::process::Command wasn't used anywhere, only used in my update, and you're right it dosen't require the .exe extension,however your update still won't work (I guess you're asuming that crate utils::shell uses std::process::Command, it's not)

[HeyItsGilbert]

I'm not sure specifying the extension is needed. https://doc.rust-lang.org/std/process/struct.Command.html#platform-specific-behavior