perf(ui): defer results fetch to render-eligible ticks#1074
Draft
alexpasmantier wants to merge 3 commits into
Draft
perf(ui): defer results fetch to render-eligible ticks#1074alexpasmantier wants to merge 3 commits into
alexpasmantier wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Television::update()was running the full results pipeline (matcher lock, index computation, per-itemto_string+ clone) on every tick (~50 Hz), while the renderer only consumes new state at ~17 Hz under load and ~2 Hz idle. Under heavy load (large source streams, big corpora) the redundant work starves keystrokes and renders.Matcher::update_counts()soselect_1/take_1/ status bar stay accurate.Test plan
tv filesorfind ~ -type f | tvon a large tree — UI stays responsive while loading; typing feels snappierselect_1/take_1/take_1_fastflows still trigger correctly