Add Update Methods for Push, Contact and Device #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d states of lists.
Owner
|
Hey, thanks for the PR, I really appreciate it. Giving a cursory glance through the code, I've noticed that there are quite a few potential bugs. I'd like to get a test suite set up this weekend, so I hope you don't mind if I postpone merging until then? Thanks again. |
Author
|
Not problem at all. Can you point out the mistakes so I can learn from them? |
Owner
|
I meant mistakes in my own code, sorry. I didn't specify that. |
|
And, did you manage to setup a test suite? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was creating a Safari extension for Pushbullet using this library and I needed to update things and it didn't have the methods. I realise that this is a big pull request, I could have compartmentalise the requests but I forgot. 😄