Add basic e-mail settings to config.php #1568
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR! I will take a closer look in this.
|
|
I think it would be even better if this was configurable via the admin settings panel |
|
Hello! Thanks again for this PR. That will definitely work, but as Rimas also pointed, in the future all configuration options will get to the admin section and only the DB connection will remain to the root config.php file. For this I will have to close this PR.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems easier to update if any custom setting is contained inside config.php and thus don't get overwritten, as such I added the basic e-mail settings to config.php (see config-sample.php). Additionally I added a example for configuring exchange as a smtp server.
Please feel free to tell me, if I should change anything to get it merged.