Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic e-mail settings to config.php #1568

Closed

Conversation

ml1nk
Copy link
Contributor

@ml1nk ml1nk commented Jul 23, 2024

It seems easier to update if any custom setting is contained inside config.php and thus don't get overwritten, as such I added the basic e-mail settings to config.php (see config-sample.php). Additionally I added a example for configuring exchange as a smtp server.

Please feel free to tell me, if I should change anything to get it merged.

@alextselegidis
Copy link
Owner

Thanks for this PR!

I will take a closer look in this.

Alex Tselegidis, Easy!Appointments Creator
Need a customization? Get a free quote!

@rimas-kudelis
Copy link

I think it would be even better if this was configurable via the admin settings panel

@alextselegidis
Copy link
Owner

Hello!

Thanks again for this PR.

That will definitely work, but as Rimas also pointed, in the future all configuration options will get to the admin section and only the DB connection will remain to the root config.php file.

For this I will have to close this PR.

Alex Tselegidis, Easy!Appointments Creator
Need a customization? Get a free quote!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants