Downgrade Decap to 3.4.0 #3214
Merged
Downgrade Decap to 3.4.0 #3214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
More recent versions of Decap inadvertently introduced two dependency issues: One with external dependencies (undeclared peer dependencies) and another with internal dependencies (circular dependency resulting in module resolution failures).
These issues are present in all versions north of 3.5, so to avoid breaking builds, for now let's ignore them.
What?
Downgrade the Decap dependency to 3.4.0 which is the last stable version, and ignore updates to 3.5 and up.
Also fix a duplicate key in webpack (minor).
Anything else?
Let's undo this change once decaporg/decap-cms#7394 and decaporg/decap-cms#7405 are fixed.