fix: use self.client.base_url in acompletion method#32
Merged
alexzhang13 merged 1 commit intoalexzhang13:mainfrom Jan 7, 2026
Merged
Conversation
The acompletion method was incorrectly accessing self.base_url which doesn't exist. Changed to self.client.base_url to match the sync completion method.
lakshyaag
approved these changes
Jan 6, 2026
Contributor
lakshyaag
left a comment
lakshyaag
left a comment
There was a problem hiding this comment.
That's my bad, thanks for catching it.
Owner
|
Yeah I've been largely glossing over a lot of the client PRs but I'll add tests for them to prevent this in the future... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AttributeError: 'OpenAIClient' object has no attribute 'base_url'in async completionacompletionmethod was usingself.base_urlinstead ofself.client.base_urlcompletionmethod which correctly usesself.client.base_urlThis bug caused recursive LLM calls to fail repeatedly: