Improve the feedback provided by UpgradeTestHelper. #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, UpgradeTestHelper would fail immediately when it encountered an invalid upgrade step. This meant that a test using the helper would have to be run multiple times to flush out all the errors. This change enhances the helper to combine all the errors into a single failure message where possible: - All public upgrade steps that should be package-visible will be shown as a single failure. - All errors relating to the sequence, UUID, Jira ID, and description will be shown as a single failure.
RadikalJin
approved these changes
Mar 19, 2025
jsimlo
requested changes
Mar 20, 2025
morf-testsupport/src/main/java/org/alfasoftware/morf/testing/UpgradeTestHelper.java
Outdated
Show resolved
Hide resolved
morf-testsupport/src/main/java/org/alfasoftware/morf/testing/UpgradeTestHelper.java
Outdated
Show resolved
Hide resolved
|
jsimlo
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, UpgradeTestHelper would fail immediately when it encountered an invalid upgrade step. This meant that a test using the helper would have to be run multiple times to flush out all the errors.
This change enhances the helper to combine all the errors into a single failure message where possible: