Open
Conversation
Author
|
The lint error doesn't relate the PR I think. |
|
The state of the PR is confusing to me. Somehow, the PR's commits have not ended up in the master branch and are not part of version 0.14.0 of this create. Can you please check this? Update: Somehow a different fix for this issue already is in the master branch, just not yet released towards crates.io. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for making this library!
When using an mp4-file encoded by AWS Transcoder, we get an error reading it
avcc not found. The problem is thatAvc1Boxexpects the first child to be theAvcCbox, and it isn't.Using
exiftool -v2we see there is apaspbox first:This PR makes it so Avc1Box loops children and skips any that isn't the AvcC box.