Open
Conversation
Parse and write av01 sample entry and av1C configuration box per AV1-ISOBMFF binding spec. Adds MediaType::AV1, Av1Config, reader/writer integration in stsd/track/mp4copy, and integration test against a real AV1+AAC sample file. Closes alfg#139
Owner
|
Hey @thexeos, thanks for the contribution. If you could check out the clippy errors when you have a chance, please.
|
There was a problem hiding this comment.
Pull request overview
Adds AV1 (av01/av1C) support to the MP4 parser/writer so AV1 tracks can be detected, parsed from stsd, and exercised via tests and the mp4copy example (closes #139).
Changes:
- Introduce
MediaType::AV1andMediaConfig::Av1Configwiring through track read/write paths. - Add parsing/writing for
av01sample entry andav1Cconfiguration box. - Add an integration test reading a real AV1+AAC MP4 sample, plus update
mp4copyto recognize AV1.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/lib.rs | Adds integration test asserting AV1 track parsing from a real sample file. |
| src/types.rs | Adds MediaType::AV1 and Av1Config / MediaConfig::Av1Config variants. |
| src/track.rs | Detects AV1 tracks from stsd.av01 and supports writing AV1 sample entries. |
| src/mp4box/stsd.rs | Extends stsd to read/write an av01 sample entry. |
| src/mp4box/mod.rs | Registers av01/av1C box types and exposes Av01Box. |
| src/mp4box/av01.rs | Implements Av01Box and Av1CBox read/write + unit tests. |
| examples/mp4copy.rs | Adds AV1 handling when copying tracks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5ae0f0c to
e266a1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse and write av01 sample entry and av1C configuration box per AV1-ISOBMFF binding spec. Adds MediaType::AV1, Av1Config, reader/writer integration in stsd/track/mp4copy, and integration test against a real AV1+AAC sample file.
Closes #139