Use cached properties, string methods#31
Merged
Merged
Conversation
alganet
force-pushed
the
modernization-refactor
branch
from
f6119fd to
e368f60
Compare
alganet
changed the title
There was a problem hiding this comment.
Pull request overview
This PR refactors the codebase to use Python's built-in @cached_property decorator and modern string methods for improved code clarity and maintainability.
- Replaced manual caching implementation with
@cached_propertydecorator for theaioaccessor - Updated string manipulation to use
removeprefix/removesuffixinstead of string slicing - Updated test to reflect the new caching mechanism
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apywire/runtime.py | Replaced manual _aio_accessor caching logic with @cached_property decorator for the aio property |
| apywire/wiring.py | Replaced string slicing with removeprefix/removesuffix methods in _extract_placeholder_name |
| tests/test_edge_cases.py | Updated test comments and assertions to reflect @cached_property usage instead of manual caching |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brief description of changes.
Type of Change
Checklist