Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces Cython compilation to apywire for performance optimization while updating project infrastructure to support Python 3.10+ and ensuring REUSE compliance. The changes simplify type annotations by removing generic type parameters and modernize the build system with proper Cython integration.
Key changes:
- Add Cython compilation support via new setup.py with SPDX header preservation
- Remove generic type parameters (
[T]) fromWired,wire(), andcompile()for Cython compatibility - Extend Python version support to include 3.10 and 3.11 in addition to existing 3.12 and 3.13
- Update SPDX headers across all files with consistent formatting for REUSE 3.0 compliance
- Add test assertion to verify caching behavior in
Wiredobjects - Restructure build commands with separate
build(Cython compilation) anddist(package distribution) targets
Reviewed Changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| apywire/wiring.py | Removed generic type parameters, simplified type aliases, updated cast to Callable for Cython compatibility |
| tests/test_simple.py | Removed generic type annotation from Wired, added caching behavior test assertion |
| setup.py | New file implementing Cython build with SPDX header injection for generated C files |
| pyproject.toml | Added Cython dependencies, Python 3.10/3.11 support, coverage configuration, simplified license field |
| Makefile | Added reuse target, restructured build/dist targets, updated coverage and all commands |
| .github/workflows/ci.yml | Extended CI matrix to test Python 3.10 and 3.11 |
| .github/workflows/release.yml | Changed build command from make build to make dist |
| .gitignore | Added Cython artifacts (*.c, *.so, build/) |
| Multiple markdown files | Updated SPDX header format from inline to block comments |
| .github/copilot-instructions.md | Updated build/publish workflow documentation, removed generic type usage example |
| .github/dependabot.yml | Formatting cleanup in SPDX header |
| REUSE.toml | Added trailing newline |
- Introduce Cython compilation for performance optimization - Update SPDX headers across codebase for REUSE compliance - Simplify type annotations and modernize build system - Enhance CI/CD workflows and development tooling - Support for Python >=3.10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brief description of changes.
Type of Change
Checklist