Conversation
xnorpx
commented
Jun 28, 2026
| Opus, | ||
| PCMU, | ||
| PCMA, | ||
| /// AMR Wideband (RFC 4867), 16 kHz mono telephony/IMS audio. |
xnorpx
commented
Jun 28, 2026
| pub max_red: Option<u32>, | ||
|
|
||
| /// AMR-WB specific parameter (RFC 4867). | ||
| /// |
Collaborator
Author
There was a problem hiding this comment.
make it clearer this is just for parsing and we don't support it
xnorpx
commented
Jun 28, 2026
| } | ||
|
|
||
| if c0.channels != c1.channels { | ||
| if !Self::channels_match(c0, c1) { |
Collaborator
Author
There was a problem hiding this comment.
not related, leave alone
xnorpx
commented
Jun 28, 2026
| return true; | ||
| } | ||
|
|
||
| if c0.codec == Codec::AmrWb && c1.codec == Codec::AmrWb { |
xnorpx
commented
Jun 28, 2026
| return None; | ||
| } | ||
|
|
||
| // Interleaving and robust sorting add RTP payload fields/layouts that |
Collaborator
Author
There was a problem hiding this comment.
put these higher up?
xnorpx
commented
Jun 28, 2026
| pub const FORTY_EIGHT_KHZ: Frequency = Self::make(48_000); | ||
|
|
||
| /// Cycles in a second of a 16 kHz signal. | ||
| pub const SIXTEEN_KHZ: Frequency = Self::make(16_000); |
Collaborator
Author
There was a problem hiding this comment.
will be available in G.722
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not ready, need more iterations