Skip to content

fix(client): fix empty check for integer timeouts #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lucas-aragno
Copy link
Contributor

Maybe I'm missing something but after upgrading to the latest version of the gem my timeout settings started breaking:

::Algolia::SearchClient.create(
    app_id,
    api_key,
    {
      connect_timeout: 5_000
    }
  )

The error seemed to be caused by the new empty? checks that were added previous to the client initialization. Why are we now checking for both nil? and empty? is the idea to use strings now? that doesn't seem to be the case since the default seem to be numbers. So let me know if this was an error or maybe we need to update the documentation on how to set up timeouts.

Thanks!

Copy link

github-actions bot commented Apr 2, 2025

Thanks for contributing to our API clients! Sorry to close your PR, but this repository is fully generated, you can port your changes to the API Clients Automation repository. If you need some guidance, feel free to open an issue or read our contribution guide.

@github-actions github-actions bot closed this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant