fix(client): fix empty check for integer timeouts #511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe I'm missing something but after upgrading to the latest version of the gem my timeout settings started breaking:
The error seemed to be caused by the new
empty?
checks that were added previous to the client initialization. Why are we now checking for both nil? and empty? is the idea to use strings now? that doesn't seem to be the case since the default seem to be numbers. So let me know if this was an error or maybe we need to update the documentation on how to set up timeouts.Thanks!