style: General code improvements #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cartridges/int_algolia_sfra/cartridge/scripts/hooks/order/algoliaHooks.js
Outdated
Show resolved
Hide resolved
ede-somogyi-algolia
changed the title
sbellone
reviewed
Dec 17, 2025
test/unit/int_algolia/scripts/algolia/helper/productFilter.test.js
Outdated
Show resolved
Hide resolved
test/unit/int_algolia/scripts/hooks/order/__snapshots__/algoliaHooks.test.js.snap
Show resolved
Hide resolved
ede-somogyi-algolia
force-pushed
the
feat/vargroup-model/sfcc-466-simple-product-fallback
branch
from
e3de939 to
cdd5f96
Compare
ede-somogyi-algolia
force-pushed
the
feat/code-improvements/20251208
branch
from
c7629c1 to
2e061ca
Compare
ede-somogyi-algolia
force-pushed
the
feat/code-improvements/20251208
branch
from
381d04c to
69377d4
Compare
sbellone
approved these changes
Dec 23, 2025
Base automatically changed from
feat/vargroup-model/sfcc-466-simple-product-fallback
to
feat/sfcc-450
December 23, 2025 20:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General code improvements
IdtoIDas per SFCC naming conventions