feat: [SFCC-468] Exposed variation attribute as a site preference in the Algolia BM module #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cartridges/int_algolia_sfra/cartridge/scripts/hooks/order/algoliaHooks.js
Outdated
Show resolved
Hide resolved
Reverted changes to end-to-end test file
ede-somogyi-algolia
force-pushed
the
feat/vargroup-model/sfcc-468-1-rename-variation-group-level-record-type
branch
from
9629378 to
3cd937e
Compare
…ord as a site preference in BM
ede-somogyi-algolia
force-pushed
the
feat/vargroup-model/sfcc-468-2-expose-variation-attribute-as-site-preference
branch
from
73ffb11 to
3a8c8d0
Compare
ede-somogyi-algolia
force-pushed
the
feat/vargroup-model/sfcc-468-2-expose-variation-attribute-as-site-preference
branch
from
86930e2 to
e6a7634
Compare
sbellone
reviewed
Dec 23, 2025
cartridges/bm_algolia/cartridge/templates/resources/algolia.properties
Outdated
Show resolved
Hide resolved
cartridges/bm_algolia/cartridge/templates/resources/algolia.properties
Outdated
Show resolved
Hide resolved
cartridges/bm_algolia/cartridge/templates/resources/algolia.properties
Outdated
Show resolved
Hide resolved
…edRecordModel_GroupingAttribute
sbellone
approved these changes
Dec 23, 2025
Base automatically changed from
feat/vargroup-model/sfcc-468-1-rename-variation-group-level-record-type
to
feat/sfcc-450
December 23, 2025 21:09
…se-variation-attribute-as-site-preference
ede-somogyi-algolia
deleted the
feat/vargroup-model/sfcc-468-2-expose-variation-attribute-as-site-preference
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created new site preference
AttributeSlicedRecordModel_GroupingAttributewhich takes the place of the hardcoded 'color' value for the grouping variation attribute for the "Attribute-sliced" record model.The Algolia BM module was updated in such a way that the value of the new site preference is only editable if the user selectes the "Attribute-sliced" record model.
The code throws an error and returns if the user selected the "Attribute-sliced" record model but haven't set
AttributeSlicedRecordModel_GroupingAttributeas well.Testing notes
system-objecttype-extensions.xmlfirst!variationModel.getProductVariationAttribute('<attribute>')won't return anything and indexing falls back to the master-type record (all variations in the same record).