Skip to content

fix: SFCC-476: Local size and color variation attribute values not retrieved correctly by aggregatedValueHandlers #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ede-somogyi-algolia wants to merge 4 commits into
base: develop
Choose a base branch
from
+5 −2
Open

fix: SFCC-476: Local size and color variation attribute values not retrieved correctly by aggregatedValueHandlers #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b41286c
Fixed local size and color variation attribute values not returned by…
ede-somogyi-algolia Nov 27, 2025
5b54827
Fixed unit test for change
ede-somogyi-algolia Nov 27, 2025
23f8ee4
Added explanatory comment for workaround
ede-somogyi-algolia Dec 22, 2025
61d2ee3
Fixed unit test
ede-somogyi-algolia Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions cartridges/int_algolia/cartridge/scripts/algolia/model/algoliaLocalizedProduct.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,8 @@ var aggregatedValueHandlers = {
var colorAttribute = variationModel.getProductVariationAttribute('color');
return (colorAttribute && variationModel.getSelectedValue(colorAttribute))
? variationModel.getSelectedValue(colorAttribute).displayValue
: null;
: product.custom.color; // this is a workaround to retrieve color values which are otherwise not returned properly by the API via the variation model, likely due to an SFCC bug. It either returns the color value that `getSelectedValue()` couldn't or `null` as before.

},
refinementColor: function (product) {
return ObjectHelper.safelyGetCustomAttribute(product.custom, 'refinementColor')
Expand All @@ -325,7 +326,7 @@ var aggregatedValueHandlers = {
var sizeAttribute = variationModel.getProductVariationAttribute('size');
return (sizeAttribute && variationModel.getSelectedValue(sizeAttribute))
? variationModel.getSelectedValue(sizeAttribute).displayValue
: null;
: product.custom.size; // this is a workaround to retrieve size values which are otherwise not returned properly by the API via the variation model, likely due to an SFCC bug. It either returns the size value that `getSelectedValue()` couldn't or `null` as before.
},
refinementSize: function (product) {
return ObjectHelper.safelyGetCustomAttribute(product.custom, 'refinementSize')
Expand Down
2 changes: 2 additions & 0 deletions test/mocks/dw/catalog/Variant.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ class Variant extends MasterProduct {
}
}
},
size: null,
color: null,
displaySize: '14cm',
refinementSize: '4',
get algoliaTest() {
Expand Down
Loading