refactor(docusaurus-adapter): rework theme config for v5 and modularize SearchPage#2904
Open
dylantientcheu wants to merge 2 commits into
Open
refactor(docusaurus-adapter): rework theme config for v5 and modularize SearchPage#2904dylantientcheu wants to merge 2 commits into
dylantientcheu wants to merge 2 commits into
Conversation
…ze SearchPage Drops the legacy themeConfig.algolia config in favor of themeConfig.docsearch exclusively (with searchPage.path replacing searchPagePath), removes the lodash dependency, and splits the monolithic SearchPage into dedicated components, hooks, and utils for maintainability. Co-authored-by: Cursor <cursoragent@cursor.com>
dylantientcheu
requested review from
8bittitan,
NatanTechofNY,
pipeline1987,
shortcuts and
vascobettencourt
as code owners
❌ Deploy Preview for docsearch failed.
|
❌ Deploy Preview for docsearch-demo failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
themeConfig.algoliasupport in favor ofthemeConfig.docsearchonly, replacingsearchPagePathwithsearchPage.path/searchPage: falselodash/utility-typesdependencies from the adapter and adds@docsearch/core,@docsearch/modal,@docsearch/sidepanel, andsearch-insightsas direct depsSearchPageinto dedicatedcomponents/,hooks/,constants.ts,types.ts, andutils.tsfor maintainabilityvalidateThemeConfigschemas (e.g..unknown(false)on side panel schemas) and updates docs/examples accordinglyadapters/**/src/**/*.test.tsto the Vitest include globs so adapter tests run in the workspace test suiteTest plan
bun run test --run adapters/docusaurus-theme-search-algolia/src/__tests__/validateThemeConfig.test.tspasses (23/23)bun run test:typesbun run lint