Skip to content

Conversation

@shaejaz
Copy link
Contributor

@shaejaz shaejaz commented Nov 3, 2025

Summary
CR-8645

This PR enables facets to still be hidden when they pass a sortBy based on the renderingContent from the engine.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 3, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e9242d6:

Sandbox Source
example-instantsearch-getting-started Configuration
example-react-instantsearch-getting-started Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-react-instantsearch-next-routing-example Configuration
example-vue-instantsearch-getting-started Configuration

@shaejaz shaejaz marked this pull request as ready for review November 3, 2025 12:23
@shaejaz shaejaz requested a review from Haroenv November 3, 2025 12:23
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, but let's add tests indeed

@shaejaz shaejaz changed the title fix(refinementList): hide facets when searchable or sortBy is enabled fix(refinementList): hide facets when when refinementList is searched Nov 4, 2025
@Haroenv Haroenv changed the title fix(refinementList): hide facets when when refinementList is searched fix(refinementList): hide facets when when refinementList has sortBy Nov 4, 2025
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@shaejaz shaejaz changed the title fix(refinementList): hide facets when when refinementList has sortBy fix(refinementList): hide facets when when sortBy is provided Nov 4, 2025
@shaejaz shaejaz requested a review from Haroenv November 5, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants