fix(refinementList): hide facets based on renderingContent when searched
#6792
+81
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 928bf34:
|
Haroenv
previously approved these changes
Nov 4, 2025
Haroenv
dismissed
their stale review
actually not yet, there are no new tests. Code looks good though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CR-8645
This PR enables facets to still be hidden when they are searched from the refinementList search box. With the isolated index change, the helper should have the
searchForFacetValuesfn defined. This prevents thelastResultsfrom being null like it was the case for themainHelper.Also fixed helper tests which wrongly passed due to array splicing logic that was used before.