Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 41276be:
|
Haroenv
requested review from
a team,
FabienMotte and
aymeric-giraudet
and removed request for
a team
dhayab
left a comment
dhayab
left a comment
There was a problem hiding this comment.
This looks good to me, although I'm wondering if at this stage, it wouldn't be better to move all jobs to GH instead. Wdyt?
| - name: Trigger release if latest commit is a release commit | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: npx shipjs@0.26.0 trigger |
There was a problem hiding this comment.
Does this still require NPM_TOKEN or have you enabled trusted publishing?
There was a problem hiding this comment.
good catch! one of the things I couldn't check without doing a release 😅
There was a problem hiding this comment.
If it's not too complex, I'd recommend relying on trusted publishing then.
Could be interesting, but I believe pricing for circleci is better than GitHub actions. To check! |
By being on github actions, we no longer need a bot account, as it can use the github token generated by actions. This also means you no longer need to run release locally with a github token to prepare a release, you can start it from the github actions page.
Haroenv
force-pushed
the
chore/ci-no-github-token
branch
from
6b7967f to
a1f51fd
Compare
Haroenv
changed the title
3 participants
Summary
migrate releasing from circleci to GitHub actions
Result
By being on github actions, we no longer need a bot account, as it can use the github token generated by actions.
This also means you no longer need to run release locally with a github token to prepare a release, you can start it from the github actions page.
FX-3682