Open
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Migrated the project from Algolia SDK v3 to v4
Breaking Changes
Four user-facing breaking changes (documented in the upgrade doc):
1.
SearchClientnamespace movedIf you inject or type-hint
SearchClientdirectly, update the FQCN:The search.client service ID and autowiring alias are updated automatically.
2. $requestOptions no longer auto-detects flat HTTP headers
v3's RequestOptionsFactory auto-routed X-* keys to headers. v4 does not.
3. SearchServiceResponse::wait() no longer accepts parameters
v3 accepted $requestOptions to customize the wait behavior. v4 does not.
4. SearchServiceResponse no longer extends AbstractResponse
SearchServiceResponse is now a standalone class. If you type-hint or instanceof check against the SDK's AbstractResponse, update to use SearchServiceResponse directly.