fix: remove profile subdomain alert side channel (#201)#289
Open
tomaspinkas-com wants to merge 1 commit into
Open
fix: remove profile subdomain alert side channel (#201)#289tomaspinkas-com wants to merge 1 commit into
tomaspinkas-com wants to merge 1 commit into
Conversation
|
|
tomaspinkas-com
force-pushed
the
fix/remove-subdomain-enumeration-alert-201
branch
from
eb9d306 to
1609240
Compare
tomaspinkas-com
force-pushed
the
fix/remove-subdomain-enumeration-alert-201
branch
from
1609240 to
4f4085c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$## Summary
Why
Issue #201 points out that
canonical_host/2performed a handle lookup and emitted a critical alert only when the subdomain matched a real user handle. That creates an internal side channel for username/subdomain enumeration.Fixes #201