Skip to content

Fix OAuth redirect pending actions#304

Open
iccccccccccccc wants to merge 1 commit into
algora-io:mainfrom
iccccccccccccc:fix-oauth-redirect-pending-actions
Open

Fix OAuth redirect pending actions#304
iccccccccccccc wants to merge 1 commit into
algora-io:mainfrom
iccccccccccccc:fix-oauth-redirect-pending-actions

Conversation

@iccccccccccccc
Copy link
Copy Markdown

Summary

This finishes the remaining OAuth popup migrations from #137, but keeps the pending action alive across the redirect round trip.

The important bit is that these flows cannot just redirect to GitHub and hope the old LiveView socket is still around. Before leaving the page, the pending action is now cached through AlgoraWeb.LocalStore; when GitHub redirects back, the page restores that state and replays the original action.

Updated flows:

  • Crowdfund bounty/tip creation
  • Swift bounty/tip creation
  • Org bounty creation
  • Org settings GitHub app installation

Fixes #137

Checks

  • Parsed the touched LiveView files with Elixir's parser
  • git diff --check

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update all OAuth flows to use redirect callback instead of sending messages from a popup window

2 participants