-
Notifications
You must be signed in to change notification settings - Fork 494
simulate: resource population #6015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joe-p
wants to merge
74
commits into
algorand:master
Choose a base branch
from
joe-p:feat/populate_resources
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
74 commits
Select commit
Hold shift + click to select a range
5ba0a9a
ResourcePopulator
joe-p 028b8c4
TestPopulatorWithGlobalResources (arrays only)
joe-p 941ba6e
test addBox
joe-p a69091c
use ElementsMatch
joe-p d9e77ef
addHolding
joe-p 4667647
test variable renaming
joe-p cbd1d8a
appLocals
joe-p d79780f
restore default limits
joe-p e6d59ba
fix rekey field
joe-p 54cd38c
populate with static properties and remove zeroAddr
joe-p 673b03d
empty boxes
joe-p ceddaa2
ensure duplicates are removed
joe-p 62213a0
overflow txn resources
joe-p f616449
use ConsensusParams
joe-p 6a4f1ee
fix empty box count
joe-p 0524c3c
golangci-lint
joe-p 73e5b4c
Merge branch 'master' into feat/populate_resources
joe-p 6d8c161
PopulateResourceArrays in simulate (untested)
joe-p 022c565
populate from ResourceTracker
joe-p 93dd4e9
initial TestPopulateResources
joe-p 3f78752
group sharing and no group sharing TestPopulateResources
joe-p 359b5b0
test with non appl in group
joe-p 2229b0a
modify visibility on resource pop stuff
joe-p ec7a36a
remove duplicate partitiontest.PartitionTest(t)
joe-p 351f915
don't make RekeyTo address available
joe-p 99abd2f
add PopulateResourceArrays to simulate API (WIP)
joe-p 96f1af1
Apply suggestions from code review
joe-p 02534ae
Apply suggestions from code review
joe-p 0815e29
PopulateResourceArrays -> PopulateResources
joe-p b4f7f54
static -> prefilled
joe-p e665817
replace ifs with switch
joe-p c9e6e5d
hasAccount short circuit logic
joe-p 2ea34f2
check for room and return error in add... methods
joe-p 93e7b81
mixed resources test
joe-p 292a9b9
use arrays in txn and group result rather than map[int] for API (WIP)
joe-p 035ef72
only populate resources when there's no error
joe-p daa0e1f
only make ExtraResourceArrays if any extra resources exist
joe-p 41d63dd
properly check for nil err
joe-p 7353379
expect an empty box ref
joe-p 64fd855
Merge branch 'master' into feat/populate_resources
joe-p db6f01b
update extra resource arrays description
joe-p affa449
TestPopulatorWithAlreadyAvailableResources
joe-p c4091e0
TestPopulatorWithNoRoom
joe-p cf29efb
check all txns to see if they have a resource before adding
joe-p e2f08c3
ensure all txn fields are accounted for to ensure there are no dups
joe-p bc58ba6
test no room for empty box ref
joe-p e29877d
use consensus params for each max ref
joe-p 989e746
remove printlns
joe-p 7a8e98c
Merge remote-tracking branch 'upstream/master' into feat/populate_res…
joe-p 8dfad71
rename variable to avoid shadowing struct
joe-p 791df53
fix extra resource array indexing, add e2e test for extra arrays
joe-p fd2c8dc
ensure resource population is deterministic
joe-p 413893f
add comment on conditional
joe-p 63c487c
address reviewdog errors
joe-p 5d680b8
fix typo
joe-p 2e28fa4
move header comment above func
joe-p b7bda2e
add TestGetTotalRefs
joe-p fc8b37a
fix extra resources check
joe-p 6353f3b
refactor: simplify sort functions
joe-p d879600
refactor: move err declaration
joe-p 0290ac3
refactor: use slice helper functions
joe-p 6567445
feat: reverse sort box apps and add comments/logic for 0 index
joe-p 32a51d6
chore: fix typos
joe-p eaef8ec
chore: add additional comment explaining resource array map
joe-p 0df1e0f
fix: add back errounesouly removed box population
joe-p 757f205
Merge branch 'master' into feat/populate_resources
joe-p a253291
fix: add reject version to app tests
joe-p a5ceee9
refactor: use two slices.Contains instead of Concat
joe-p 081e62e
refactor: move addr checks before app checks
joe-p 0d0d481
refactor: remove redundant .String()
joe-p dcd2d59
refactor: rm AppIndex instantiation
joe-p 0f528de
refactor: use slices.Sorted and maps.Keys for assigning values
joe-p 74c9b8f
refactor: rm unused anon struct
joe-p 489d950
refactor: use second iterator value
joe-p File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm basically agnostic on this question: Do you think this should be present if it's empty? I lean toward it not appearing, but don't care too much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think mirroring the behavior of
unnamed-resources-accessed
(not being a required field) makes the most sense