Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: implement GetTotalMemory for mac and windows #6272

Merged
merged 3 commits into from
Mar 13, 2025

Conversation

algorandskiy
Copy link
Contributor

@algorandskiy algorandskiy commented Mar 11, 2025

Summary

Nightly macos build failed with

util/util.go:82:18: undefined: syscall.Sysinfo_t
util/util.go:83:18: undefined: syscall.Sysinfo

Implemented GetTotalMemory for macos and windows.

Test Plan

Added a unit test.

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 51.70%. Comparing base (cbfa226) to head (164fca1).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
util/util_linux.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6272   +/-   ##
=======================================
  Coverage   51.69%   51.70%           
=======================================
  Files         646      647    +1     
  Lines       86860    86858    -2     
=======================================
+ Hits        44901    44906    +5     
+ Misses      39095    39084   -11     
- Partials     2864     2868    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@algorandskiy algorandskiy requested a review from jannotti March 13, 2025 17:21
@algorandskiy algorandskiy merged commit f6cc4e2 into algorand:master Mar 13, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants