refactor: replace deprecated 'golang.org/x/exp/rand' to 'math/rand/v2' #6274
+5
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yudrywet <[email protected]>
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6274 +/- ##
==========================================
- Coverage 51.69% 51.68% -0.01%
==========================================
Files 646 646
Lines 86860 86860
==========================================
- Hits 44901 44893 -8
- Misses 39095 39103 +8
Partials 2864 2864 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jannotti
reviewed
Mar 12, 2025
| @@ -488,7 +488,7 @@ func TestAppRateLimiter_TxgroupToKeys(t *testing.T) { | |||
| } | |||
|
|
|||
| func BenchmarkAppRateLimiter_TxgroupToKeys(b *testing.B) { | |||
| rnd := rand.New(rand.NewSource(123)) | |||
| rnd := rand.New(rand.NewPCG(0, 123)) | |||
There was a problem hiding this comment.
If you use this: rnd := rand.NewChaCha8(seed) you won't have to change the Read() calls, I think.
There was a problem hiding this comment.
Oh, it does seem so. I want to write a detailed demo to try it out later.
There was a problem hiding this comment.
I used pseudo-random numbers in assumption they are a bit faster than reading crypto/rand source.
chacha should be fine - it appears to maintain all it state in memory, no syscalls/etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
golang.org/x/exp/rand will be deprecated. Use math/rand/v2 in std.
For more info can see https://go.dev/issue/61716.
Test Plan