Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: box paging #6279

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

API: box paging #6279

wants to merge 2 commits into from

Conversation

jannotti
Copy link
Contributor

Offer search by prefix and paging.

Summary

Test Plan

Pagination, and perhaps value returns to come.
oas2, going to db no matter what, sorting

Still need to order the db results (so we ensure we get the earliest
possible boxes), and start the scan from from `after`.
@jannotti jannotti self-assigned this Mar 17, 2025
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 18.91892% with 60 lines in your changes missing coverage. Please review.

Project coverage is 51.68%. Comparing base (272ec02) to head (5295cba).

Files with missing lines Patch % Lines
daemon/algod/api/server/v2/handlers.go 20.00% 24 Missing ⚠️
...edger/store/trackerdb/generickv/accounts_reader.go 0.00% 7 Missing ⚠️
...ver/v2/generated/nonparticipating/public/routes.go 0.00% 6 Missing ⚠️
ledger/acctupdates.go 57.14% 4 Missing and 2 partials ⚠️
ledger/store/trackerdb/sqlitedriver/sql.go 0.00% 6 Missing ⚠️
...dger/store/trackerdb/dualdriver/accounts_reader.go 0.00% 5 Missing ⚠️
daemon/algod/api/client/restClient.go 0.00% 3 Missing ⚠️
libgoal/libgoal.go 0.00% 2 Missing ⚠️
cmd/goal/box.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6279      +/-   ##
==========================================
+ Coverage   51.63%   51.68%   +0.04%     
==========================================
  Files         647      647              
  Lines       86907    86946      +39     
==========================================
+ Hits        44876    44934      +58     
+ Misses      39161    39144      -17     
+ Partials     2870     2868       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant