Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Exporter: update dependencies and add darwin universal support #6280

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

onetechnical
Copy link
Contributor

Summary

Node exporter is provided to optionally expose metrics for algod. This PR updates the binary with algorand/node_exporter#9 changes. The binaries were collected from the Github Actions artifacts.

The Darwin binaries were lipoed into a universal binary. The Makefile was updated so that if built from a universal target (which would set CROSS_COMPILE_ARCH) it should use universal target. A regular make should use the arch-specific target.

Test Plan

Verified make pulled an arch-specific target, while make universal pulled the universal target.

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.68%. Comparing base (272ec02) to head (b1f5ad5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6280      +/-   ##
==========================================
+ Coverage   51.63%   51.68%   +0.04%     
==========================================
  Files         647      647              
  Lines       86907    86907              
==========================================
+ Hits        44876    44918      +42     
+ Misses      39161    39122      -39     
+ Partials     2870     2867       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant