network: remove GossipNode.BroadcastArray #6281
Open
+110
−181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cce
commented
Mar 17, 2025
network/wsPeer.go
Outdated
|
|
||
| if highPrio { | ||
| outchan = wp.sendBufferHighPrio | ||
| } else { | ||
| outchan = wp.sendBufferBulk | ||
| } | ||
| select { | ||
| case outchan <- sendMessages{msgs: msgs}: | ||
| case outchan <- sendMessage{data: data, enqueued: msgEnqueueTime, peerEnqueued: time.Now(), hash: digest, ctx: ctx}: |
There was a problem hiding this comment.
As far as I can tell, there are no users of the hash field on sendMessage.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6281 +/- ##
==========================================
- Coverage 51.63% 50.82% -0.81%
==========================================
Files 647 647
Lines 86907 86874 -33
==========================================
- Hits 44876 44156 -720
- Misses 39161 39790 +629
- Partials 2870 2928 +58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
algorandskiy
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #1966 the methods BroadcastArray and RelayArray were added to the GossipNode interface. (The idea was to break up long messages like proposals into a sequence of smaller messages, to allow canceling a proposal while it was still being sent, as soon as a better one was observed.) However they were never used, and have no callers. They require every (tag, message) pair, to be wrapped in two single-element []protocol.Tag and [][]byte slices. This PR attempts to see if it is straightforward (and more performant) to go back to single-message sending, without the slice wrappers.
Review recommended with whitespace hidden.
Test Plan
Updated TestWebsocketNetworkCancel and TestPreparePeerData for missing BroadcastArray. Existing unit & e2e test should ensure that networking is still working with single messages.