Algod API: Get connected peers #6500
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 6 Tests Failed:
View the top 1 failed test(s) by shortest run time
View the full list of 5 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
daemon/algod/api/algod.oas2.json
Outdated
| } | ||
| ] | ||
| }, | ||
| "/v2/peers": { |
Contributor
There was a problem hiding this comment.
idk, maybe it should go to /v2/node/peers or similar (along with the shutdown) in order to keep the root "namespace" contained?
| } | ||
| }, | ||
| "/v2/shutdown": { | ||
| "/v2/node/shutdown": { |
Contributor
There was a problem hiding this comment.
thank you for implementing. Technically this is API change. I guess the best way of action is:
- to mark it deprecated (deprecated: true)
- continue calling the shutdown method under it is old/current path along with the new one.
Author
There was a problem hiding this comment.
Good catch. Implemented in 229f033
Thank you for taking the time to review this.
Contributor
|
Latest patch adds visibility of all libp2p peers , including pubsub only connections, where algorand-ws protocol is not used. This is going to change once consensus migrates away from algorand-ws.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request implements two ways to query the node's current peers:
GET /v2/peersgoal node peers