test: wallet utils Jira tests - #571
Draft
joe-p wants to merge 10 commits into
Draft
Conversation
BREAKING CHANGE: v10 beta release --------- Co-authored-by: David Rojas <lempira@gmail.com> Co-authored-by: Hoang Dinh <patrick.dinh@makerx.com.au> Co-authored-by: Neil Campbell <neil.campbell@makerx.com.au> Co-authored-by: David Rojas <lempira@users.noreply.github.com> Co-authored-by: Al <7698600+aorumbayev@users.noreply.github.com> Co-authored-by: Luca Martini <luca.martini@algorand.foundation> Co-authored-by: mrcointreau <45950216+mrcointreau@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…e-link docs: fix broken api reference link
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new “wallet utils” polytest-derived Vitest suite to exercise HD wallet derivation, multisig flows, transaction review/signing/export, and staking/keyreg scenarios against LocalNet (and one MainNet block lookup).
Changes:
- Add new
tests/wallet_utils/*epic test suites plus shared helpers intests/wallet_utils/common.ts. - Add
@scure/bip39(dev dependency) to support BIP39 mnemonic generation/seed derivation used by the new tests. - Add
polytest:*wallet*npm scripts intended to generate/run the wallet polytests.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/wallet_utils/epic_ak_992.test.ts | Adds HD derivation + multisig + migration tests. |
| tests/wallet_utils/epic_ak_1000.test.ts | Adds view-only, balance aggregation, ASA/NFT balance tests. |
| tests/wallet_utils/epic_ak_1001.test.ts | Adds payment, grouped transactions, multisig payment, ASA/NFT send, ARC2 note, fee check tests. |
| tests/wallet_utils/epic_ak_1002.test.ts | Adds transaction review/sign/export + arbitrary data signing tests. |
| tests/wallet_utils/epic_ak_1003.test.ts | Adds staking/keyreg + rewards lookup + staking status classification tests. |
| tests/wallet_utils/common.ts | Introduces shared helper utilities for balance/HD derivation/asset lookups. |
| package.json | Adds wallet polytest scripts and @scure/bip39 devDependency. |
| package-lock.json | Locks @scure/bip39 and transitive dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+146
to
+147
| const mainnet = AlgorandClient.mainNet() | ||
| const block = await mainnet.client.algod.block(round) |
There was a problem hiding this comment.
This test hits MainNet via AlgorandClient.mainNet() and fetches a real block. That makes the unit/integration test suite dependent on external network availability and third-party infrastructure (AlgoNode), which can cause CI flakiness. Consider moving this to a separate “network-required” test suite, or gating/skipping it unless an explicit env flag is set, and/or using a mocked algod response instead.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
joe-p
force-pushed
the
test/wallet_utils_stories
branch
from
April 23, 2026 15:31
f5402a9 to
90b1f7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on algorandfoundation/algokit-polytest#26
Some notes:
@scure/bip39lib is being used for HD mnemonics. The plan is to add this directly into AlgoKit and generally expose all HD functionality through AlgoKit