Cooley-Tukey in Scala #746
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berquist
added
the
Implementation
Vexatos
suggested changes
Oct 3, 2020
| def cooleyTukey(signal: IndexedSeq[Double]): IndexedSeq[Complex] = signal.length match { | ||
| case 2 => mergeTransforms( | ||
| Vector(new Complex(signal(0), 0)), | ||
| Vector(new Complex(signal(1), 0))) |
There was a problem hiding this comment.
shouldn't the last parenthesis be on a separate line for this code style?
There was a problem hiding this comment.
I couldn't find anything in the style guide on that topic, but all the examples put the closing paren on the same line, so I did it as well.
| val oddTerms = for (i <- odds.indices) | ||
| yield coefficient(1, i, 2 * odds.length) * odds(i) | ||
|
|
||
| val pairs = evens.zip(oddTerms) |
There was a problem hiding this comment.
Wouldn't you need to calculate even terms too?
There was a problem hiding this comment.
No, because only the odd values are multiplied with the coefficients. The 'evenTerms' would just be the 'evens' parameter.
|
[lang: scala] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FFT implementation in Scala.
The code (hopefully) follows this style guide: https://docs.scala-lang.org/style/index.html
A runnable version of the code is on Repl.it: https://repl.it/@Delphi1024/FFT-Algorithm-Archive#main.scala
~Delphi1024