Skip to content

Conversation

@Guo-Peilin
Copy link
Collaborator

No description provided.

build:disc_aarch64 --linkopt="-Xlinker --stub-group-size -Xlinker 10000000"
build:disc_aarch64 --action_env BUILD_WITH_AARCH64=1
build:disc_aarch64 --experimental_local_memory_estimate
build:disc_aarch64 --jobs=10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is 10 too small for parallelism? @qiuxiafei @Yancey1989

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about determining this number according to the number of the cores on the machine

Copy link

@qiuxiafei qiuxiafei Feb 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, 10 is usually to small. And as on different machines, number of cores varies, there won't be a fit-for-all number. How about --local_cpu_resources/--local_ram_resources here: https://bazel.build/docs/user-manual#local-resources

build:disc_cpu --config=disc --cxxopt=-DTAO_CPU_ONLY
build:disc_x86 --config=disc_cpu --config=release_cpu_linux --cxxopt=-DTAO_X86 --define disc_x86=true
build:disc_aarch64 --config=disc_cpu --cxxopt=-DTAO_AARCH64 --define disc_aarch64=true --linkopt="-Xlinker --stub-group-size -Xlinker 10000000"
build:disc_aarch64 --config=disc_cpu --cxxopt=-DTAO_AARCH64 --define disc_aarch64=true --linkopt="-Xlinker --stub-group-size -Xlinker 10000000" --experimental_local_memory_estimate --local_ram_resources=HOST_RAM*.5 --local_cpu_resources=HOST_CPUS*.5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be more aggressive? How about 80% of RAM and 90% of CPU

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants