Skip to content

[wip] Master-slave deployment #4579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

zhanglei1949
Copy link
Collaborator

WIP

zhanglei1949 and others added 14 commits March 12, 2025 10:03
Committed-by: xiaolei.zl from Dev container

Committed-by: xiaolei.zl from Dev container

impl service discovery, todo: impl in c++ side

Committed-by: xiaolei.zl from Dev container

remove comments

Committed-by: xiaolei.zl from Dev container

Committed-by: xiaolei.zl from Dev container
Committed-by: [email protected] from Dev container

Committed-by: [email protected] from Dev container

code refactor

Committed-by: [email protected] from Dev container

Committed-by: [email protected] from Dev container

Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
…: make end-to-end test work and fix image building
Committed-by: xiaolei.zl from Dev container
Committed-by: zhanglei1949 from Dev container
Copy link
Contributor

github-actions bot commented Mar 20, 2025

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification
and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "[wip] Master-slave deployment". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - build
 - ci
 - docs
 - feat
 - fix
 - perf
 - refactor
 - test
 - chore

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.72%. Comparing base (d39709a) to head (85ab5ab).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #4579       +/-   ##
===========================================
+ Coverage   44.76%   65.72%   +20.96%     
===========================================
  Files          12      102       +90     
  Lines         592    11449    +10857     
===========================================
+ Hits          265     7525     +7260     
- Misses        327     3924     +3597     

see 114 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d39709a...85ab5ab. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the stale label May 12, 2025
Copy link
Contributor

/cc @yecol @sighingnow, this issus/pr has had no activity for a long time, please help to review the status and assign people to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants