Skip to content

fix(interactive): fix ldbc data importing in Groot #4583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

BingqingLyu
Copy link
Collaborator

What do these changes do?

  1. Fix in ldbc schema
  2. When importing the data, do not convert empty string to nan

Related issue number

#4581

Committed-by: bingqing.lbq from Dev container

Committed-by: bingqing.lbq from Dev container
Committed-by: bingqing.lbq from Dev container

Committed-by: bingqing.lbq from Dev container
Committed-by: bingqing.lbq from Dev container
Committed-by: bingqing.lbq from Dev container
This reverts commit 112890f.

Committed-by: bingqing.lbq from Dev container
Copy link
Contributor

github-actions bot commented Mar 25, 2025

Please check the preview of the documentation changes at
https://a6e4f3ca.graphscope-docs-preview.pages.dev

This reverts commit d1c728a.

Committed-by: bingqing.lbq from Dev container
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.02%. Comparing base (5bcefbd) to head (eba64e7).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4583      +/-   ##
==========================================
- Coverage   35.01%   33.02%   -2.00%     
==========================================
  Files         127      127              
  Lines       13299    13299              
==========================================
- Hits         4657     4392     -265     
- Misses       8642     8907     +265     

see 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bcefbd...eba64e7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the stale label Apr 12, 2025
Copy link
Contributor

/cc @yecol @sighingnow, this issus/pr has had no activity for a long time, please help to review the status and assign people to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants