[OpenCL:Feature] Accelerate MmapAllocator::read by replacing per-call lseek+read with mmap-based memcpy#4323
Closed
Riverspring996 wants to merge 2 commits into
Closed
Conversation
…ls with mmap-based memcpy
Collaborator
|
Thank you for your code commit. We have already addressed this issue internally, and the latest code has now been pulled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The cached file is already mapped at onAlloc time, so each read can be a plain memcpy from the pre-established mapping rather than issuing lseek+read syscalls, eliminating both the kernel syscall and the kernel-to-user copy.
Validation
Measured total wall-clock time of OpenCLMmapAllocator::read during model loading via Android ATrace, with multiple warm-up launches to exclude cold page-fault. Results confirm a reduction about 30% in OpenCLMmapAllocator::read and 14% in total loading.