[Infra:Chore] Remove CoreML suffix from iOS release package#4608
Merged
Conversation
wangzhaode
marked this pull request as ready for review
July 9, 2026 09:30
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| PACKAGENAME: mnn_${{ needs.setup.outputs.VERSION }}_ios_armv82_cpu_metal | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| with: |
There was a problem hiding this comment.
将 iOS 的打包名称从 mnn_..._metal_coreml 修改为 mnn_..._metal，移除了 coreml 标记。请确认此更改是否符合预期（例如是否确实不再包含 CoreML 相关构建产物）。如果确实移除了 CoreML，建议检查仓库中是否有其他脚本或文档硬编码了旧的包名，确保下游发布流程和文档已同步更新，避免出现找不到文件的错误。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
coremlsuffix from the iOS artifact name produced by themnn_releaseworkflow.Why
The iOS release job currently builds through
package_scripts/ios/buildiOS.sh, which enables Metal but does not pass-DMNN_COREML=ON. Since CoreML is not included in that package, the artifact suffix was misleading.Impact
Release artifacts now better match the actual backend configuration: iOS arm64 + ARM82 + CPU + Metal.
Validation
git diff --cached --check.