[OpenCL:Chore] Update shared_gather_buf md5 after kernel fix in #4659#4660
Open
Qxinyu wants to merge 1 commit into
Open
[OpenCL:Chore] Update shared_gather_buf md5 after kernel fix in #4659#4660Qxinyu wants to merge 1 commit into
Qxinyu wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shared_gather_buf.clfix updated the embedded kernel source (shared_gather_buf_mnn_cl.cpp) but not its entry inOpenCLProgramMd5Map(opencl_source_map.hpp), becauseopencl_codegen.pywrites that header to the script's CWD rather than the cl/ directory.74b2cbe8...→7bfae0b1..., verified by re-running the codegen — the only real md5 change in the regenerated map).Test plan
opencl_codegen.pyfrom the cl/ directory and confirmedshared_gather_bufis the only md5 that differs; all other diffs are brace-formatting noise (reverted).